-
Notifications
You must be signed in to change notification settings - Fork 5k
Rebalanced roundstart items: Trinkets #42427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Rebalanced roundstart items: Trinkets #42427
Conversation
|
The removals are a shame (mostly the candles, though I doubt that many other people used them as a central character element, so it's understandable) and the additions are nice, wristwatches'll definitely be fun to have |
I used them :( |
|
Sidenote but we really need to shrink the sprites so the loadout list entry isn't so big |
I like the sprites being big since it makes it easier to tell what the trinkets actually look like. I wear glasses though. |
|
I understand why the human plushie was excluded but adding every other plushie rubs salt in the wound |
Possibly. The sprite is naked though so it might still be too cartoonish, I'm not sure. In any case that'd need to be its own PR. Thought it does now occur to me that the vox plushie also screams, and we do have vox chittering sounds now. I might open a small PR to swap that sound effect out since it'd probably be a better fit. |
I went through the human sounds and in a similar or even the same PR you could use the crying emote for the human plushie (Still comedic, doesnt convey emergency nearly as much, isnt super offputting) since humans dont have a similar chattering sound and laughing sounds slightly offputting to hear from a plushie |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…on-14 into moss-roundstartitems-trinkets Merged master into branch
…on-14 into moss-roundstartitems-trinkets Merged master into branch
About the PR
Rebalanced the items in the Trinkets loadout tab (some additions, some removals). Marked as draft until the roundstart equipment design doc is merged.
I'd also like to mention a distinct but related PR (#41264) that moves canes from the Trinkets tab to a new "Assistive items" tab.
Why / Balance
The roundstart equipment design doc is nearing completion, and #42423 has been opened already to work on implementing its additions in Medical, so I'm going to open some PRs for other things as well.
The decision to remove candles, lighters, smokables, and folders was made to match the design doc; "Trinkets are the non-clothing items available in a loadout. These are RP props used to establish a unique character, and should say something about your character's personality. They should not be used to shortcut finding readily available and common items (like cigarettes) or to give yourself an advantage with some special functionality."
In regards to the additions:
I'll note that removing existing trinkets that don't fit with the design doc is far more important here than adding new trinkets, so I'm willing to remove the new additions from this PR if necessary. That being said, it's probably better to add new options all at once that than to have a bunch of tiny future PRs that all need to be reviewed individually.
Technical details
Media
Requirements
Breaking changes
N/A
Changelog
🆑