[SpaceCore] Feature: Draw behaviours for custom buff effects #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fold all parsing behaviours into `SkillBuff.TryGetAdditionalBuffEffects` method with `out` params for parsed values, returning false on null input or no output. - Run all buff string formatting through `SkillBuff.FormattedBuffEffect` method for consistency. - Move all buff draw behaviours to `SkillBuff.DrawBuffEffect` method, with `DrawHealthRegenBuffEffect` and `DrawStaminaRegenBuffEffect` methods allowing arbitrary draw behaviours for SpaceCore specific buff effects.
…HoverText transpiler: - Replace yield-by-index transpiler with CodeMatcher solution. - Draw additional buff effects (health and stamina regen) below health, above divider. - Draw custom skill buff effects above basic skill effects, below divider. - Custom skill buff effects use the same spacing as basic skill effects.
|
the dramatic comparison Before
After
|
|
So apparently my reorganizing the repository created conflicts for every single PR. I figured the PR system would be smart enough to handle files being moved around fine, but I guess not. I plan on manually merging this soon with some rebase shenanigans, so no need to worry about fixing this. I'll leave the PR open until it's taken care. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites some methods on SpaceCore to better allow for arbitrary draw calls from other mods (read: love of cooking), and fixes some minor presentation issues relating to custom buff effects since SDV1.6.
Changes
SkillBuffbehaviours into their individual steps, made accessible to other programs.ParseCustomFieldsmethod with newTryGetAdditionalBuffEffectsmethod, return success and all parsed buff custom skill buff effects and attributes from parsedCustomFieldsdictionaries.Transpile_IClickableMenu_DrawHoverTextmethod contents withCodeMatchersolution for added precision since SDV1.6 changes to hover text draw behaviours.Fixes