[SpaceCore] Feature: IngredientMatcher usability #531
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame members for clarity; fix typos.
|
So apparently my reorganizing the repository created conflicts for every single PR. I figured the PR system would be smart enough to handle files being moved around fine, but I guess not. I plan on manually merging this soon with some rebase shenanigans, so no need to worry about fixing this. I'll leave the PR open until it's taken care. |
|
Manually merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exposes some members of IngredientMatcher for better usability from other mods (i.e. Love of Cooking, as usual) and improves readability a little.
Changes
public abstract Matches(Item item)method toIngredientMatcherto allow external mods to compare items for crafting.objectIndex->_itemId, orObjectIngredientMatcher->ItemIngredientMatcher).Fixes
IngredientMatcher.DispayName).VAECustomCraftingRecipe.Descriptionreturning item display name instead of description.