Skip to content

Fix 515.1621 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Fix 515.1621 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc9deaa
Fix 515.1621
AffectedArc07 Mar 5, 2025
1086a0e
Lets try matrix this
AffectedArc07 Mar 5, 2025
a18e550
Oh god I bought actions debugging to byondapi
AffectedArc07 Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
feature_flags: [byond-515-1621, byond-516-1651]
os: [ubuntu-latest, windows-latest]
include:
- os: ubuntu-latest
target_name: i686-unknown-linux-gnu
Expand Down Expand Up @@ -39,7 +41,7 @@ jobs:
with:
toolchain: stable
command: check
args: --target ${{ matrix.target_name }}
args: --target ${{ matrix.target_name }} --no-default-features --features ${{ matrix.feature_flags }}

check_fmt:
name: Check format
Expand Down
7 changes: 6 additions & 1 deletion crates/byondapi-rs-test/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,12 @@ edition = "2021"
crate-type = ["cdylib"]

[dependencies]
byondapi = { path = "../byondapi-rs" }
byondapi = { path = "../byondapi-rs", default-features = false }
tempfile = "3.17.1"
cargo_metadata = "0.19.1"
eyre = "0.6.12"

[features]
default = ["byond-516-1651"]
byond-515-1621 = ["byondapi/byond-515-1621",]
byond-516-1651 = ["byondapi/byond-516-1651"]
2 changes: 2 additions & 0 deletions crates/byondapi-rs/src/value/functions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ impl ByondValue {

/// Replaces whatever is currently in this value with a string that's pointed to by the stringid
/// # DO NOT PASS STRINGIDS THAT ARE NOT RETURNED BY [`crate::byond_string::str_id_of`]
#[cfg(feature = "byond-516-1651")]
pub fn set_strid(&mut self, strid: u4c) {
unsafe { byond().ByondValue_SetStrId(&mut self.0, strid) }
}
Expand Down Expand Up @@ -249,6 +250,7 @@ impl ByondValue {
unsafe { byond().ByondValue_DecRef(&self.0) }
}

#[cfg(feature = "byond-516-1651")]
pub fn decrement_tempref(&mut self) {
unsafe { byond().ByondValue_DecTempRef(&self.0) }
}
Expand Down