fix: hydration mismatch + offline hook rewrite#27
Merged
Conversation
- Add suppressHydrationWarning to <html> element to prevent React hydration mismatch from inline theme script setting data-theme - Rewrite useOnlineStatus() with useSyncExternalStore (React 19 pattern) to eliminate flash of offline notice and avoid setState-in-effect lint - Hardened OfflineNotice with aria-live and role=alert
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues discovered during local testing:
Hydration mismatch — The inline theme script sets
data-themeon<html>during HTML parsing, but the server-rendered HTML doesn't have it. AddedsuppressHydrationWarningto<html>(standard Next.js pattern for theme toggling).Offline notice false positive — Rewrote
useOnlineStatus()withuseSyncExternalStoreto eliminate flash of offline notice and align with React 19 best practices.Checklist