Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to centralize and simplify how tests handle environment-driven skipping/failing (network-dependent tests and “extension not loaded” tests), and to expose these behaviors via Composer scripts and CI.
Changes:
- Refactors the two “no extension”
.phpttests to use a sharedskipIfExtensionLoaded()helper. - Enhances
tests/bootstrap.phpskip messages and addsskipIfExtensionLoaded()helper. - Adds a
tester-include-skippedComposer script and updates docs/CI workflow to use it; restructurestester/tester-no-extensionsscripts.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Signature/Providers/SecurityTxtSignatureGnuPgProviderNoExtensionTest.phpt | Uses shared helper instead of inline extension/env-var logic. |
| tests/Fetcher/HttpClients/SecurityTxtFetcherCurlClientNoExtensionTest.phpt | Uses shared helper instead of inline extension/env-var logic. |
| tests/bootstrap.php | Adds skipIfExtensionLoaded() and improves skip messaging for network tests. |
| composer.json | Introduces tester-include-skipped and restructures tester scripts (currently problematic). |
| CLAUDE.md | Documents the new composer tester-include-skipped command. |
| .github/workflows/php-tester-include-skipped.yml | Switches CI to run composer tester-include-skipped. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spaze
force-pushed
the
spaze/tests-env-vars
branch
from
38d949c to
e653e75
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…twork Sets the `TEST_CASE_RUNNER_INCLUDE_SKIPPED=1` env var
spaze
force-pushed
the
spaze/tests-env-vars
branch
from
e653e75 to
20ae8d7
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.