Conversation
Possible starting with PHP 8.4 Close #92
There was a problem hiding this comment.
Pull request overview
This PR updates the CLI entrypoint to pass exit as a first-class callable (removing the intermediate $exit closure), and bumps PHPStan to a version that supports this construct. It also includes a small variable renaming in JSON result reconstruction.
Changes:
- Replace the
$exitwrapper closure withexit(...)when constructingSecurityTxtCheckHostCli. - Bump
phpstan/phpstanfrom^2.1.45to^2.1.47. - Rename loop variables in
SecurityTxtJson::createCheckHostResultFromJsonValues()for line error/warning processing.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
bin/checksecuritytxt.php |
Uses exit(...) as the injected exit callable for the CLI runner. |
composer.json |
Updates PHPStan to a newer patch version needed for analysis support. |
src/Json/SecurityTxtJson.php |
Refactors variable names while reconstructing line errors/warnings from JSON values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolves PHPStan's "Foreach overwrites $line with its key variable."
spaze
force-pushed
the
spaze/new-phpstan
branch
from
c1a905f to
75852fe
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible starting with PHP 8.4.
Requires the latest PHPStan.
Close #92