Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the CLI output formatting so success messages use a consistent green [OK] prefix while leaving the rest of the line uncolored (except the final “valid/invalid” summary lines, which remain fully colored).
Changes:
- Introduce
ConsolePrinter::ok()to print[OK]with green coloring. - Update
SecurityTxtCheckHostClito use[OK]for “expires in …” and “Signature valid …” lines, and adjust final summary wording to “The file is valid/invalid”. - Update CLI
.phptexpectations and add contributor guidance about ANSI bytes in test heredocs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/Check/SecurityTxtCheckHostCliTest.phpt | Updates expected CLI output to match the new [OK] formatting and revised summary line. |
| src/Check/SecurityTxtCheckHostCli.php | Switches certain progress/success messages from [Info] + green text to the new [OK] printer; tweaks final summary output. |
| src/Check/ConsolePrinter.php | Adds ok() helper to standardize [OK] output formatting. |
| CLAUDE.md | Documents how Tester writes .actual/.expected files and notes that .phpt heredocs contain raw ANSI escape bytes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The [OK] string is always green, but the text following it isn't, unless it's the last line "The file is invalid"/"The file is valid" which is always full-color (red for error, green for ok).
spaze
force-pushed
the
spaze/console-colors
branch
from
e9a3a4c to
0d605f2
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
[OK]string is always green, but the text following it isn't, unless it's the last line "The file is invalid"/"The file is valid" which is always full-color (red for error, green for ok).