Conversation
…ild configurations for JavaWeaver and KadabraAPI
…tionUtils and related methods - Removed WeaverProfiler parameter from various methods in ActionUtils, AdapterGenerator, MapGenerator, and other classes. - Updated insert and new method implementations to simplify method signatures. - Cleaned up unused imports and commented-out code across multiple joinpoint classes. - Enhanced readability and maintainability by streamlining method parameters and reducing unnecessary complexity.
…son for isolated modules
…emove obsolete steps
…throw an exception during refactor
… AST code, instead of acting like a 'rebuild'
…ead operator if input is an array
…structure and readability
…into fix/kadabra-js-tests
… a "woven_code" folder inside the given output folder
Fixes Kadabra-JS failing tests
… more controlled versioning
There was a problem hiding this comment.
Pull request overview
This PR deprecates the Lara DSL approach by removing auto-generated abstract join point classes and related infrastructure, transitioning to a different implementation strategy for the JavaWeaver join point hierarchy.
Changes:
- Removed 22+ auto-generated abstract join point classes (AFile, AField, AClass, ACall, etc.)
- Updated AJavaWeaverJoinPoint to remove SelectOp dependency and rename def methods to set methods
- Deleted the JavaWeaver.dotty join point hierarchy visualization file
Reviewed changes
Copilot reviewed 53 out of 427 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| AFile.java | Removed auto-generated file join point class |
| AFieldAccess.java | Removed auto-generated field access join point class |
| AField.java | Removed auto-generated field join point class |
| AExpression.java | Removed auto-generated expression join point class |
| AExecutable.java | Removed auto-generated executable join point class |
| AEnumValue.java | Removed auto-generated enum value join point class |
| AEnum.java | Removed auto-generated enum join point class |
| ADeclaration.java | Removed auto-generated declaration join point class |
| AContinue.java | Removed auto-generated continue statement join point class |
| AConstructor.java | Removed auto-generated constructor join point class |
| AComment.java | Removed auto-generated comment join point class |
| AClass.java | Removed auto-generated class join point class |
| ACatch.java | Removed auto-generated catch join point class |
| ACase.java | Removed auto-generated case join point class |
| ACallStatement.java | Removed auto-generated call statement join point class |
| ACall.java | Removed auto-generated call join point class |
| ABreak.java | Removed auto-generated break statement join point class |
| ABody.java | Removed auto-generated body join point class |
| AAssert.java | Removed auto-generated assert statement join point class |
| AJavaWeaverJoinPoint.java | Removed SelectOp import, renamed defLineImpl to setLineImpl methods, removed generic select function, changed toAStatement return type |
| JavaWeaver.dotty | Removed join point hierarchy visualization file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| @Override | ||
| public void defLineImpl(Integer value) { | ||
| public void setLineImpl(int value) { |
There was a problem hiding this comment.
The method signature change from defLineImpl(Integer value) to setLineImpl(int value) changes from boxed Integer to primitive int. This could cause issues if null values were previously handled or if callers pass null, as primitives cannot be null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.