Lara dsl deprecation #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaobispo
reviewed
Oct 2, 2025
WeaverGenerator/src-jmh/org/lara/interpreter/weaver/generator/benchmarks/SpecFactory.java
Show resolved
Hide resolved
joaobispo
reviewed
Oct 2, 2025
WeaverGenerator/src/org/lara/interpreter/weaver/generator/commandline/WeaverGenerator.java
Outdated
Show resolved
Hide resolved
joaobispo
reviewed
Oct 2, 2025
WeaverGenerator/test/org/lara/interpreter/weaver/generator/fixtures/SpecXmlBuilder.java
Show resolved
Hide resolved
joaobispo
reviewed
Oct 2, 2025
WeaverInterface/src/org/lara/interpreter/joptions/config/interpreter/LaraIKeyFactory.java
Show resolved
Hide resolved
… default value selection
…rence determination
There was a problem hiding this comment.
Pull request overview
This PR removes deprecated LARA DSL-related code as part of a cleanup effort. The changes involve deleting numerous auto-generated parser AST (Abstract Syntax Tree) files and the Gradle settings file.
- Removal of approximately 100+ auto-generated AST node classes from the LARA ECMAScript parser
- Deletion of the Gradle settings configuration file
- All removed files were generated code (marked with "Generated By:JavaCC" or "Generated By:JJTree" headers)
Reviewed changes
Copilot reviewed 177 out of 1295 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| JJTLARAEcmaScriptState.java | Removed auto-generated parser state management class |
| AST*.java (multiple files) | Removed auto-generated AST node classes for various language constructs (statements, expressions, declarations, etc.) |
| settings.gradle | Removed Gradle build configuration with project dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nd LaraiStoreDefinition classes.
…or module cache bypass
…import for module cache bypass" This reverts commit 6d37bb8.
…itself when only a single array argument
lm-sousa
commented
Jan 10, 2026
Comment on lines
+151
to
+153
| addJps(jps: LaraJoinPoint[]) { | ||
| jps = arrayFromArgs(jps) as LaraJoinPoint[]; | ||
|
|
Member
Author
There was a problem hiding this comment.
@joaobispo Is this change still supposed to be here?
Member
Author
There was a problem hiding this comment.
You'll need to open up the merge diff view because the diff in this page looks to be quite broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.