feat: improve debug handling in Builder and Client #4
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstance() - fix: preserve debug flag by passing $this->debug to client - feat: default setDebug() to true when no argument is provided
| * | ||
| * This is reset to false after the request | ||
| */ | ||
| public function debug(bool $debug = true): self |
Member
There was a problem hiding this comment.
I get all of the changes, but this is a rename. What are your thoughts on that?
It was debug in the Builder as that class is more about the human-readable experience, so it has the default & is used as just $builder->debug() as it reads better. Under the hood, the client is setting debug true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves propagation of the debug flag between Builder and Client so that Guzzle debug output works consistently across nested builder instances.
Ensures expected visibility during local testing and easier troubleshooting without affecting normal runtime behavior.