Skip to content

Update Go import paths to spinframework #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamreese
Copy link
Contributor

This updates the go documentation to the new import path included in the templates.

Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing a lot of seemingly unrelated diffs in the PR. Would it be possible to split it into separate "Markdown linter" and "functional changes" PRs? The current structure makes it hard to know which files to dig into for the actual Go changes I'm afraid.

@adamreese
Copy link
Contributor Author

Trailing spaces have returned

Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Should this merge immediately or is this part of 3.4? (I'm guessing immediately but wanted to double check.)

@adamreese
Copy link
Contributor Author

Should this merge immediately or is this part of 3.4?

Good callout. Templates are part of the release, right? The updated templates aren't in a released version. It doesn't need to be directly tied to the templates but it's an extra step to change the import. It might be better for new folks if we wait.

@itowlson itowlson added the v-next This is not in the current release of Spin: it is expected to land in the next release. label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v-next This is not in the current release of Spin: it is expected to land in the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants