feat(sqlite): implement sqlite in wasip2 #25
Conversation
|
Worth squashing commits? |
|
Squished |
| allowed_outbound_hosts = [] | ||
| sqlite_databases = ["default"] | ||
| [component.sqlite.build] | ||
| command = "tinygo build -target=wasip2 --wit-package $(go list -mod=readonly -m -f '{{.Dir}}' github.com/spinframework/spin-go-sdk/v3)/wit --wit-world http-trigger -gc=leaking -o main.wasm main.go" |
There was a problem hiding this comment.
Will the $(go list ...) work on Windows?
There was a problem hiding this comment.
hmm, go list should work, but not sure about $(go list...). I had opened a ticket ydnar/wasi-http-go#22 to check with other folks if there is a better way to do this.
| case "text": | ||
| ret[i] = *v.Text() | ||
| case "blob": | ||
| // TODO: check this |
There was a problem hiding this comment.
Good call, It's not. For some reason blob columns are being returned as text. I'm still tracing it.
v3/sqlite/sqlite.go
Outdated
| rows := &rows{ | ||
| columns: cols, | ||
| rows: allrows, | ||
| len: int(rowLen), |
There was a problem hiding this comment.
Is there a reason to hold this separately - e.g. is len(allrows) expensive to calculate?
There was a problem hiding this comment.
It was copy pasta that I left in because it spares the cost of len(allrows) on each iteration of .Next(). TBH I'm not sure if it saves all that much.
v3/examples/sqlite/main.go
Outdated
| db := sqlite.Open("default") | ||
| defer db.Close() | ||
|
|
||
| _, err := db.Query("REPLACE INTO pets VALUES (4, 'Maya', ?, false);", "bananas") |
There was a problem hiding this comment.
could we pls also add init schema in this example. I tried running it and ran into no such table: pets. Also if you think that is out of scope, maybe a small readme file to initiate that db manually would be great.
There was a problem hiding this comment.
actually now that i tried creating table myself, its not that hard.
sqlite3 .spin/sqlite_db.db
<copy paste from db/pets.sql>
so feel free to ignore my previous comment 👍
There was a problem hiding this comment.
Spin Can Do That! spin up --sqlite @db/pets.sql
adamreese
force-pushed
the
wasip2-sqlite
branch
from
08fd1cc to
c188a77
Compare
Signed-off-by: Adam Reese <[email protected]>
adamreese
force-pushed
the
wasip2-sqlite
branch
from
c188a77 to
27c9b9d
Compare
No description provided.