-
Notifications
You must be signed in to change notification settings - Fork 8
feat(redis): implement redis in wasip2 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this is not a problem at all. happy to review this implementation. could you please take redis example from existing wasip1 code, and make sure it works with wasip2. Also we need to implement redis-inbound. If you want to do that as a separate PR, that is fine as well. 👍 |
5f195da
to
b058ceb
Compare
Thanks for the feedback! I adjusted the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some initial feedback. I'll do some manual testing next
// Removes the specified keys. | ||
// | ||
// A key is ignored if it does not exist. Returns the number of keys deleted. | ||
func (c *Client) Del(keys ...string) (uint32, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to future self: Looks like some return types changed. This was int64.
Signed-off-by: Andrew Steurer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking on outbound redis!
I didn't realize that @rajatjindal may have already been working the Redis portion until I had already written everything 😬 . My feelings won't be hurt if we need to scrap this one in favor of his implementation.
closes #26