Skip to content

Conversation

asteurer
Copy link

@asteurer asteurer commented Aug 7, 2025

I didn't realize that @rajatjindal may have already been working the Redis portion until I had already written everything 😬 . My feelings won't be hurt if we need to scrap this one in favor of his implementation.

closes #26

@rajatjindal
Copy link
Member

didn't realize that @rajatjindal may have already been working the Redis portion until I had already written everything 😬 . My feelings won't be hurt if we need to scrap this one in favor of his implementation.

this is not a problem at all. happy to review this implementation.

could you please take redis example from existing wasip1 code, and make sure it works with wasip2. Also we need to implement redis-inbound. If you want to do that as a separate PR, that is fine as well. 👍

@asteurer asteurer force-pushed the wasip2-redis branch 2 times, most recently from 5f195da to b058ceb Compare August 7, 2025 20:50
@asteurer
Copy link
Author

asteurer commented Aug 7, 2025

Thanks for the feedback! I adjusted the redis-outbound example to match the wasip1 example; however, I had to alter the NewClient method to return an error, which is an alteration to the API. Let me know if that needs to change. I tried to get the redis-inbound working; however, it got complicated haha. I'll try it in another PR.

Copy link
Contributor

@adamreese adamreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's some initial feedback. I'll do some manual testing next

// Removes the specified keys.
//
// A key is ignored if it does not exist. Returns the number of keys deleted.
func (c *Client) Del(keys ...string) (uint32, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to future self: Looks like some return types changed. This was int64.

Copy link
Contributor

@adamreese adamreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on outbound redis!

@adamreese adamreese merged commit aaeb45a into spinframework:wasip2 Aug 27, 2025
2 checks passed
@asteurer asteurer deleted the wasip2-redis branch August 27, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants