Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Kawron
left a comment
There was a problem hiding this comment.
-
Remove comments from main package parser or add those comments to lite package as well. Just make sure that the content of those files is exactly the same, so if someone will try to search it by copying pasting the code he will get both results.
-
I can see that we used in the test case the log that was put in the public issue page by the reporter. That means that this is probably public data, however I personally would still change some of the data in this log just to make sure we don't publish any sensetive information. So for example I would change the HOSTAMDDOS to SOMEHOST, changed the ip addresses to 0.0.0.0 and etc
Beside those two issues, everything looks good
No description provided.