Skip to content

Fix/netscout host issue#2954

Merged
digrajpu merged 5 commits intodevelopfrom
fix/netscout_host_issue
Mar 10, 2026
Merged

Fix/netscout host issue#2954
digrajpu merged 5 commits intodevelopfrom
fix/netscout_host_issue

Conversation

@digrajpu
Copy link
Collaborator

@digrajpu digrajpu commented Mar 9, 2026

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@digrajpu digrajpu requested a review from Kawron March 9, 2026 12:55
Copy link
Collaborator

@Kawron Kawron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove comments from main package parser or add those comments to lite package as well. Just make sure that the content of those files is exactly the same, so if someone will try to search it by copying pasting the code he will get both results.

  2. I can see that we used in the test case the log that was put in the public issue page by the reporter. That means that this is probably public data, however I personally would still change some of the data in this log just to make sure we don't publish any sensetive information. So for example I would change the HOSTAMDDOS to SOMEHOST, changed the ip addresses to 0.0.0.0 and etc

Beside those two issues, everything looks good

@digrajpu digrajpu self-assigned this Mar 10, 2026
@Kawron Kawron self-requested a review March 10, 2026 07:32
@digrajpu digrajpu marked this pull request as ready for review March 10, 2026 07:37
@digrajpu digrajpu requested a review from rjha-splunk as a code owner March 10, 2026 07:37
@digrajpu digrajpu merged commit d3c55a9 into develop Mar 10, 2026
19 of 24 checks passed
@digrajpu digrajpu deleted the fix/netscout_host_issue branch March 10, 2026 07:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants