Skip to content

fix(security): 2 improvements across 2 files - #286

Open
tomaioo wants to merge 2 commits into
sportsdataverse:mainfrom
tomaioo:fix/security/insecure-http-used-for-api-data-retrieva
Open

fix(security): 2 improvements across 2 files#286
tomaioo wants to merge 2 commits into
sportsdataverse:mainfrom
tomaioo:fix/security/insecure-http-used-for-api-data-retrieva

Conversation

@tomaioo

@tomaioo tomaioo commented Jul 17, 2026

Copy link
Copy Markdown

Summary

fix(security): 2 improvements across 2 files

Problem

Severity: High | File: sportsdataverse/cfb/cfb_teams.py:L44

The espn_cfb_teams function and the mlbam_copyright_info function both use http:// instead of https:// to download data. This exposes the application to Man-in-the-Middle (MITM) attacks, where an attacker could intercept or alter the data being fetched.

Solution

Change http://site.api.espn.com/... to https://site.api.espn.com/... to ensure encrypted communication.

Changes

  • sportsdataverse/cfb/cfb_teams.py (modified)
  • archive/mlb/mlb_loaders.py (modified)

Summary by CodeRabbit

  • Security Improvements
    • Updated MLB copyright information downloads to use a secure HTTPS connection.
    • Updated the college football teams data source to use HTTPS for safer data retrieval.

tomaioo added 2 commits July 17, 2026 05:19
- Security: Insecure HTTP used for API data retrieval
- Security: Insecure HTTP used for MLBAM copyright info

Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Insecure HTTP used for API data retrieval
- Security: Insecure HTTP used for MLBAM copyright info

Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

@tomaioo is attempting to deploy a commit to the sportsdataverse Team on Vercel.

A member of the Team first needs to authorize it.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @tomaioo, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d231afb8-cd32-4648-bbe9-e1d865569ef1

📥 Commits

Reviewing files that changed from the base of the PR and between 64848f9 and 87a654b.

📒 Files selected for processing (2)
  • archive/mlb/mlb_loaders.py
  • sportsdataverse/cfb/cfb_teams.py

📝 Walkthrough

Walkthrough

MLB copyright and ESPN college football team loaders now use HTTPS source URLs. Their download, parsing, persistence, printing, and return behavior remain unchanged.

Changes

HTTPS endpoint updates

Layer / File(s) Summary
Source URL protocol updates
archive/mlb/mlb_loaders.py, sportsdataverse/cfb/cfb_teams.py
The MLB copyright source and ESPN college football teams endpoint now use HTTPS while retaining existing request and response handling.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: saiemgilani

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects a security-focused update affecting two files, even though it is somewhat broad.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant