fix(security): 2 improvements across 2 files - #286
Conversation
- Security: Insecure HTTP used for API data retrieval - Security: Insecure HTTP used for MLBAM copyright info Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Security: Insecure HTTP used for API data retrieval - Security: Insecure HTTP used for MLBAM copyright info Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
@tomaioo is attempting to deploy a commit to the sportsdataverse Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughMLB copyright and ESPN college football team loaders now use HTTPS source URLs. Their download, parsing, persistence, printing, and return behavior remain unchanged. ChangesHTTPS endpoint updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
fix(security): 2 improvements across 2 files
Problem
Severity:
High| File:sportsdataverse/cfb/cfb_teams.py:L44The
espn_cfb_teamsfunction and themlbam_copyright_infofunction both usehttp://instead ofhttps://to download data. This exposes the application to Man-in-the-Middle (MITM) attacks, where an attacker could intercept or alter the data being fetched.Solution
Change
http://site.api.espn.com/...tohttps://site.api.espn.com/...to ensure encrypted communication.Changes
sportsdataverse/cfb/cfb_teams.py(modified)archive/mlb/mlb_loaders.py(modified)Summary by CodeRabbit