S3 vector store fix bug where Document.getText() was ignored in Put Vector#5558
Open
MatejNedic wants to merge 1 commit intospring-projects:mainfrom
Open
S3 vector store fix bug where Document.getText() was ignored in Put Vector#5558MatejNedic wants to merge 1 commit intospring-projects:mainfrom
MatejNedic wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: matejnedic <matejnedic1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I initially implemented S3 Vector Store I thought everyone would place their data in Metadata and get it from there since S3 Vector Store you cannot store the data.
Now thinking about this option to store Document.getText() should be automatically propagated by the Library making it a bug.
This feature allows automatic propagation of Document.getText() to metadata with custom header which can be changed.
Tried it against real AWS in MCP RAG setup.