Remove unset HISTFILE from post install script#25082
Remove unset HISTFILE from post install script#25082remisalmon wants to merge 2 commits intospyder-ide:masterfrom
Conversation
|
Hey @remisalmon, thanks for your contribution. You said:
Yes, it is (otherwise we wouldn't have used it). It's necessary to avoid adding shell commands to users bash/zsh history, which is really awkward, both when doing updates and getting environment variables to pass them to the IPython console and Python path manager. So, I'm afraid you'll have to find another way to work around the issue you're seeing with your antivirus(?) software. |
I mean it is not strictly necessary but I agree with that.
I did, let me know if this looks better (I reverted the changes to This issue is not specific to myself but anyone using spyder on a machine where https://en.wikipedia.org/wiki/CrowdStrike is installed, which may be common, unfortunately. Here is some more why: https://attack.mitre.org/techniques/T1562/003/ |
Description of Changes
This is removing all
unset HISTFILEshell commands: when I update spyder and the post install script runs this triggers a malicious script alerts in crowdstrike (www.crowdstrike.com) and many questions from my security team.Unsetting HISTFILE is not necessary to update sypder, so I am proposing to remove those.
Doc, for bash: https://www.gnu.org/software/bash/manual/bash.html#index-HISTFILE
Issue(s) Resolved
See above.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: remisalmon