Fix MySQL Mathematical Expression Type Inference #4172
Draft
+547
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements type inference for MySQL mathematical expressions. Before this change, queries with arithmetic operations would generate
interface{}types, which meant no compile-time type safety. Now the compiler properly infers types based on the operands and operators.Before:
After:
What changed
inferExprType()that recursively analyzes SQL expressions to determine their typesinterface{}/and%)Notes
The implementation is MySQL-specific for now. PostgreSQL and SQLite return
nilfromcombineGenericTypes()to maintain current behavior. There's a TODO comment about refactoringIsMathematicalOperator()to be engine-specific.Closes #4153