-
Notifications
You must be signed in to change notification settings - Fork 13
Discover sql server named instance ports #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover sql server named instance ports #43
Conversation
Co-authored-by: contact <[email protected]>
Co-authored-by: contact <[email protected]>
Co-authored-by: contact <[email protected]>
Co-authored-by: contact <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: contact <[email protected]>
Co-authored-by: contact <[email protected]>
Co-authored-by: contact <[email protected]>
Co-authored-by: contact <[email protected]>
|
@cursoragent If an user enters a port explicitly, then the port discovery logic should not kick in : pub struct MssqlConnectOptions {
pub(crate) host: String,
pub(crate) port: Option<u16>,So: if the user enters a port, then use it. If not, then either do port discovery, or use the default port. |
|
Perfect! I've updated the implementation to handle explicit ports correctly. Here's what changed: Changes Made1. Changed
|
Co-authored-by: contact <[email protected]>
Co-authored-by: contact <[email protected]>
Add support for SQL Server named instances to automatically resolve ports via SSRP.
This PR implements the SQL Server Resolution Protocol (SSRP) to discover the correct TCP port for named instances, allowing users to specify
instance=NAMEin connection strings. It correctly handles MBCS encoding for SSRP responses as per the specification.