Allow iOS presentation when already presenting #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a github action to publish to NPM.js. Fix dependency issues in package.json. * Updating actions/cache to v4 since GH will reject older versions * Fix package name
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
iOS does not allow presenting view controllers when one is already presented. The in-app-payments library does not handle the case of a developer trying to present the card entry form from an already presented view controller, and instead just crashes.
I have "fixed" it for the particular case for our app, however I apologize I do not have the time to flesh out the functionality for every case. Therefore this is a draft PR. Additionally, it's really only a bandaid, as the developer would still be expected to be presenting a UINavigationController for this to work (though I would imagine react-native-screens or whatever library is probably already doing that by default).
Another potential fix that I have seen used previously, is to create a separate UIWindow, layering it over top of the existing app. That would bypass the problem entirely, but require much more refactoring.
Changelog