Add onSessionCancelled API
#1432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
force-pushed
the
sedwards/add-dropped-actions-tracking
branch
from
a71b62b to
65cbb89
Compare
steve-the-edwards
force-pushed
the
sedwards/add-dropped-actions-tracking
branch
from
65cbb89 to
bf8451f
Compare
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
ijwhelan
approved these changes
Nov 18, 2025
Collaborator
ijwhelan
left a comment
ijwhelan
left a comment
There was a problem hiding this comment.
Wow, this is a great idea! 😉
steve-the-edwards
force-pushed
the
sedwards/add-dropped-actions-tracking
branch
from
bf8451f to
d78e5af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want observability into any actions that have already been queued but not yet applied at the time that a workflow node stops rendering in the tree. This is the 'end' of that
WorkflowSessionand we mark that with an optionalonSessionCancelledAPI that receives the un-handled actions.We also include the exception that caused the cancellation if there is one, as well as the workflow session instance itself.