Skip to content

Connect & Disconnect#1511

Open
andymandias wants to merge 4 commits intomainfrom
connection
Open

Connect & Disconnect#1511
andymandias wants to merge 4 commits intomainfrom
connection

Conversation

@andymandias
Copy link
Collaborator

Restructures how connection/disconnection are handled, to:

  • Allow users to manually connect to disconnected servers via sidebar context-menu
  • Allow servers to be disconnected without triggering auto-reconnect or being removed from the sidebar
  • Allow users to specify servers that should not be connected to on launch (or when added via configuration reload)

Additionally:

  • Adds context-menu entry for removing servers from the sidebar
  • Improves the handling of disconnect on SASL authentication failure
  • Re-initiates connections when the connection details are changed as part of a configuration reload

Comment on lines +731 to +732
Leave,
Remove,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename Leave to Disconnect.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up. I think its bit strange to see both Leave (Disconnect) and Remove.
Perhaps should consider only showing Remove when they are Disconnected.

We could also use the seperator like we have on a user context:

Connected:

ergo <-- name of server to keep it similar with user context
----
Close all queries
Mark server buffer as read
Mark entire server as read
Open in new pane
Open in new window
Replace current pane
Disconnect <--- Connect if disconnected
Remove <--- Only shown if disconnected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Reload configuration" does not update server credentials? Disable auto-connect Configure to not Connect to a Server on Launch

2 participants

Comments