Skip to content

Conversation

ktomk
Copy link
Contributor

@ktomk ktomk commented Jun 2, 2021

including a file that re-redefines leads to a fatal error, making phpcs
fail hard.

including files from a rule-set while these files may have already been
included (likely by auto-loading and could then be seen as a race-
condition) now checks if it has been already included and if so, searches
all loaded classes for the class-name and if found, verifies the class
is from that file.

this effectively prevents the fatal error and works for classes / files
with a PSR-4 naming scheme.

including a file that re-redefines leads to a fatal error, making phpcs
fail hard.

including files from a rule-set while these files may have already been
included (likely by auto-loading and could then be seen as a race-
condition) now checks if it has been already included and if so, searches
all loaded classes for the class-name and if found, verifies the class
is from that file.

this effectively prevents the fatal error and works for classes / files
with a PSR-4 naming scheme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant