remove invalid example for GET show netem property containerName#67
Merged
FloSch62 merged 1 commit intosrl-labs:mainfrom Feb 10, 2026
Merged
Conversation
Contributor
Author
|
a CI with automatic validation of the swagger with the official openapi tool could be nice 🙂 |
Member
|
The swagger files are auto generated by Looking at internal/api/tools_handlers.go:750, the swag annotation is: This is where the example value comes from. The PR is removing the example from the generated output files, but the annotation in the source code still has it. So the next time someone runs swag init, the example will come right back. |
Contributor
Author
|
ah didn't know that, my bad. thanks for the heads up i'll fix it. that means that my previous PR which has been merged was bad as well and was overwritten: #61 |
8a4697b to
1dc7859
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here is the output of the openapi-generator-cli with the current swagger.json:
this PR addresses the issue by removing the invalid example from the swagger