Skip to content

Clabverter Inline Startup Config Support#240

Merged
carlmontanari merged 6 commits intosrl-labs:mainfrom
bayars:clabverter_inline_startup_config
Jan 26, 2026
Merged

Clabverter Inline Startup Config Support#240
carlmontanari merged 6 commits intosrl-labs:mainfrom
bayars:clabverter_inline_startup_config

Conversation

@bayars
Copy link
Contributor

@bayars bayars commented Jan 25, 2026

Summary

  • Fix clabverter failing when startup-config contains inline content (YAML multiline "|") instead of a file path
  • Add isInlineConfig() detection by checking for newlines in config value
  • Re-serialize clabConfig when inline configs exist to update paths in topology definition

Changes

When a containerlab topology uses inline startup-config like:

startup-config: |
  /configure system name "router1"

clabverter was failing due to unexpected line error.

Test fixtures:

  • Added test case with inline startup-config for both nokia_srlinux and nokia_srsim nodes
  • Verified all 8 SR-SIM labs from containerlab repo convert successfully
  • Existing tests continue to pass

@bayars bayars marked this pull request as draft January 25, 2026 21:33
@bayars bayars marked this pull request as ready for review January 26, 2026 01:47
@carlmontanari
Copy link
Contributor

LGTM!

@carlmontanari carlmontanari merged commit ea3b7f0 into srl-labs:main Jan 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants