Topology Lifecycle State and Probe Integration #241
+592
−40
Annotations
10 errors
|
run the linters:
controllers/topology/reconcile.go#L52
avoid inline error handling using `if err := ...; err != nil`; use plain assignment `err := ...` (noinlineerr)
|
|
run the linters:
controllers/topology/reconciler.go#L839
`if listErr != nil || len(podList.Items) == 0` has complex nested blocks (complexity: 7) (nestif)
|
|
run the linters:
controllers/topology/reconcile.go#L40
`if topology.DeletionTimestamp != nil` has complex nested blocks (complexity: 9) (nestif)
|
|
run the linters:
controllers/topology/reconciler.go#L671
Function name: ReconcileDeployments, Cyclomatic Complexity: 35, Halstead Volume: 5011.83, Maintainability Index: 16 (maintidx)
|
|
run the linters:
controllers/topology/reconcile.go#L12
import "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" imported without alias but must be with alias "ctrlruntimeutil" according to config (importas)
|
|
run the linters:
controllers/topology/reconcile.go#L20
cyclomatic complexity 20 of func `(*Controller).Reconcile` is high (> 15) (gocyclo)
|
|
run the linters:
controllers/topology/reconcile.go#L52
sloppyReassign: re-assignment to `err` can be replaced with `err := c.BaseController.Client.Patch(
|
|
run the linters:
controllers/topology/reconciler.go#L671
cognitive complexity 53 of func `(*Reconciler).ReconcileDeployments` is high (> 30) (gocognit)
|
|
run the linters:
controllers/topology/reconcile.go#L20
cognitive complexity 31 of func `(*Controller).Reconcile` is high (> 30) (gocognit)
|
|
run the linters:
controllers/topology/reconcile.go#L20
Function 'Reconcile' has too many statements (56 > 50) (funlen)
|
Loading