Special-case *$... as equivalent to $....
#101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
copybara_568317031
branch
from
97ee2d6 to
578e004
Compare
This is non-ambiguous: a `$...` only "makes "sense" in a repeated context, and a `Starred()` ast node is not a repeated context. So we're free to interpret it in some other, magical way instead. Since we actually specifically want to support a syntax like `**$...`, `*$...` should match its semantics. PiperOrigin-RevId: 568317031
copybara-service
bot
force-pushed
the
copybara_568317031
branch
from
578e004 to
c430443
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special-case
*$...as equivalent to$....This is non-ambiguous: a
$...only "makes "sense" in a repeated context, and aStarred()ast node is not a repeated context. So we're free to interpret it in some other, magical way instead.Since we actually specifically want to support a syntax like
**$...,*$...should match its semantics.