feat: Enhance DeepSeek reasoning content handling #4975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: strip reasoning content for deepseek-reasoner
Contributor
Author
|
@rekram1-node, in case it's useful to resolve #4947 |
|
hopefully that can be merged upstream soon and we can get a new version out |
kcrommett
added a commit
to Latitudes-Dev/shuvcode
that referenced
this pull request
Dec 4, 2025
* ignore: update download stats 2025-12-03 * ignore: docs & style * chore: format code * add retry case for grok resource exhausted * feat: experimental.primary_tools, allow user to set the tools that should only be available to primary agents (sst#4913) Co-authored-by: GitHub Action <[email protected]> * fix: bunfs path on windows (sst#5011) * feat: add messages_last_user command to scroll TUI to last user message (implements sst#4847) (sst#4855) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Aiden Cline <[email protected]> * ci: add pr review * ci: make review only fire on non draft pr creation * zen: usage graph respect light/dark mode * ci: tweak review cmd * ci: review ready for review action * feat: add tool_details keybind w/ no default (sst#4976) Co-authored-by: Aiden Cline <[email protected]> * ci: review tweak * zen: fix chart loading closes sst#5030 * core: add provider test coverage for upcoming refactor Add comprehensive test suite for Provider module to ensure safe refactoring of provider internals. Tests cover: - Provider loading from env vars and config - Provider filtering (disabled_providers, enabled_providers) - Model whitelist/blacklist - Model aliasing and custom providers - getModel, getProvider, closest, defaultModel functions Also adds Env module for instance-scoped environment variable access, enabling isolated test environments without global state pollution. * core: refactor provider and model system (sst#5033) Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: thdxr <[email protected]> * bump opentui * Update Nix flake.lock and hashes * fix: dax typo * fix: compaction type issue * fix: provider id issue * ci: add note about iife * docs: remove outdated theme section as system theme is now added back (sst#5041) * feat: Enhance DeepSeek reasoning content handling (sst#4975) Co-authored-by: Aiden Cline <[email protected]> * release: v1.0.130 * sync: record last synced tag v1.0.130 Fixed type error in prompt.ts: model.modelID -> model.id --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Aiden Cline <[email protected]> Co-authored-by: Spoon <[email protected]> Co-authored-by: Luke Parker <[email protected]> Co-authored-by: Ariane Emory <[email protected]> Co-authored-by: Aiden Cline <[email protected]> Co-authored-by: Frank <[email protected]> Co-authored-by: Dax Raad <[email protected]> Co-authored-by: Dax <[email protected]> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: thdxr <[email protected]> Co-authored-by: Jack Bisceglia <[email protected]> Co-authored-by: Jakub Matjanowski <[email protected]> Co-authored-by: opencode <[email protected]>
kcrommett
added a commit
to Latitudes-Dev/shuvcode
that referenced
this pull request
Dec 4, 2025
* ignore: update download stats 2025-12-03 * ignore: docs & style * chore: format code * add retry case for grok resource exhausted * feat: experimental.primary_tools, allow user to set the tools that should only be available to primary agents (sst#4913) Co-authored-by: GitHub Action <[email protected]> * fix: bunfs path on windows (sst#5011) * feat: add messages_last_user command to scroll TUI to last user message (implements sst#4847) (sst#4855) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Aiden Cline <[email protected]> * ci: add pr review * ci: make review only fire on non draft pr creation * zen: usage graph respect light/dark mode * ci: tweak review cmd * ci: review ready for review action * feat: add tool_details keybind w/ no default (sst#4976) Co-authored-by: Aiden Cline <[email protected]> * ci: review tweak * zen: fix chart loading closes sst#5030 * core: add provider test coverage for upcoming refactor Add comprehensive test suite for Provider module to ensure safe refactoring of provider internals. Tests cover: - Provider loading from env vars and config - Provider filtering (disabled_providers, enabled_providers) - Model whitelist/blacklist - Model aliasing and custom providers - getModel, getProvider, closest, defaultModel functions Also adds Env module for instance-scoped environment variable access, enabling isolated test environments without global state pollution. * core: refactor provider and model system (sst#5033) Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: thdxr <[email protected]> * bump opentui * Update Nix flake.lock and hashes * fix: dax typo * fix: compaction type issue * fix: provider id issue * ci: add note about iife * docs: remove outdated theme section as system theme is now added back (sst#5041) * feat: Enhance DeepSeek reasoning content handling (sst#4975) Co-authored-by: Aiden Cline <[email protected]> * release: v1.0.130 * zen: fix chart loading * chore: format code * fix: TypeError: undefined is not an object * release: v1.0.131 * sync: record last synced tag v1.0.131 --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Aiden Cline <[email protected]> Co-authored-by: Spoon <[email protected]> Co-authored-by: Luke Parker <[email protected]> Co-authored-by: Ariane Emory <[email protected]> Co-authored-by: Aiden Cline <[email protected]> Co-authored-by: Frank <[email protected]> Co-authored-by: Dax Raad <[email protected]> Co-authored-by: Dax <[email protected]> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: thdxr <[email protected]> Co-authored-by: Jack Bisceglia <[email protected]> Co-authored-by: Jakub Matjanowski <[email protected]> Co-authored-by: opencode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve handling of reasoning content for DeepSeek tool calls to prevent API errors. Add tests to ensure correct behavior for both tool calls and final answers.