Forks #75
Forks #75
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces documentation for network forks by creating a new forks/ directory with metadata about different fork versions. The documentation includes a main README explaining the purpose and links to individual fork documents for "Alan" and "Boole" forks.
Key changes:
- Added structured documentation for tracking network fork information and associated SIPs (Standardization Improvement Proposals)
- Created individual fork documents that list approved and pending SIPs for each fork version
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| forks/README.md | Main index for the forks directory with links to individual fork documents |
| forks/alan.md | Documentation for the Alan fork, listing approved SIPs with reference to Committee Consensus |
| forks/boole.md | Documentation for the Boole fork, listing approved and pending SIPs (with placeholder links) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GalRogozinski
left a comment
GalRogozinski
left a comment
There was a problem hiding this comment.
Add:
- activation epoch: may be TBD
- Add new DomainName that is used in networking
|
|
||
| <!-- (TODO: set fork epoch) --> | ||
| - Activation Epoch: TDB | ||
| - Domain Type: `0x0002` |
There was a problem hiding this comment.
@MatheusFranco99
remind me, this new domain is hidden in some PR? If so, that's fine but for future maybe we have dedicated PR.
If no, then quickly add a new PR
Thanks!
There was a problem hiding this comment.
It isn't in any PR. Added here: ssvlabs/ssv-spec#598
GalRogozinski
left a comment
GalRogozinski
left a comment
There was a problem hiding this comment.
Thanks!
I thought about it and I think it is best to just have approves SIPs here and the extra metadata of domain and activation epoch.
For future forks we will open in discussions tab something similar to #39 under Forks category.
There people can see what was DFI and why...
After all approves SIPs are merged we will approve this one
Overview
This PR adds documents about network forks.
See discussion #77