Upgrade contract to increase max validators #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* increase validators limit to 1000
| import "../../SSVNetwork.sol"; | ||
|
|
||
| contract SSVNetworkUpgradeValidatorsPerOperator is SSVNetwork { | ||
| function initializev2(uint32 validatorsPerOperatorLimit_) external reinitializer(_getInitializedVersion() + 1) { |
There was a problem hiding this comment.
Suggested change
| function initializev2(uint32 validatorsPerOperatorLimit_) external reinitializer(_getInitializedVersion() + 1) { | |
| function initializev2(uint32 validatorsPerOperatorLimit_) external reinitializer(2) { |
I think this should do the job.
This means it can be called only once but probably it's still safer to add onlyOwner.
Contributor
Author
|
Changed |
riccardo-ssvlabs
previously approved these changes
Mar 6, 2025
riccardo-ssvlabs
left a comment
riccardo-ssvlabs
left a comment
There was a problem hiding this comment.
Approving with the following discussed assumptions:
- only the owner will be able to call the new
initializev2function - we are ok with having this function callable multiple times, so it is not a real initializer anymore but it is more similar to a set function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.