Aggregator Committee

[olegshmuelov]

ssvlabs/SIPs#61 implementation

[GalRogozinski]

So far looks good @olegshmuelov

[github-actions]

This pull request has been marked as stale due to 60 days of inactivity.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[nkryuchkov]

@greptileai please review it

[greptile-apps]

Greptile Overview

Greptile Summary

This PR implements the Aggregator Committee feature, which consolidates aggregator and sync committee contribution duties into a single runner to optimize performance and reduce consensus rounds.

Key Changes

• New AggregatorCommitteeRunner: Combines aggregator and sync committee contribution duties in a single runner that processes both types in parallel
• New consensus data type: AggregatorCommitteeConsensusData stores both aggregator attestations and sync committee contributions
• Committee support: Updated Committee struct to handle the new AggregatorCommitteeDuty type
• Validation logic: Added specific validation for aggregator committee consensus data
• Submission tracking: Proper tracking for both duty types with different granularity (aggregator: one per validator, sync committee: multiple per validator)

Implementation Quality

The implementation follows existing patterns in the codebase and includes comprehensive test coverage. The code properly handles edge cases like operators with divergent validator sets and validates consensus data before processing. The separation between aggregator duties (one submission per validator) and sync committee contributions (multiple submissions per validator by root) is correctly implemented.

Test Coverage

Extensive test files added including multi-committee spec tests with various validator counts (1, 2, 4 duties) and both attestation and sync committee scenarios. Test utilities properly generate consensus data for both pre-Electra and Electra+ versions.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The implementation follows established patterns in the codebase, includes comprehensive test coverage, and properly handles edge cases. The code is well-structured with clear separation of concerns and appropriate error handling throughout.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
ssv/aggregator_committee.go	4/5	New aggregator committee runner that combines aggregator and sync committee contribution duties. Core logic appears sound with proper state management and submission tracking.
ssv/committee.go	5/5	Updated to support AggregatorCommitteeDuty type alongside existing CommitteeDuty. Logic correctly filters validators and creates runners.
types/consensus_data.go	5/5	Added AggregatorCommitteeConsensusData type with proper validation and encoding. Supports both aggregator and sync committee contribution data.
ssv/value_check.go	5/5	Added AggregatorCommitteeValueCheckF for validating aggregator committee consensus data. Simple validation ensures data is not empty.

Sequence Diagram

sequenceDiagram
    participant Committee
    participant AggregatorCommitteeRunner
    participant BeaconNode
    participant Network
    participant QBFT

    Committee->>AggregatorCommitteeRunner: StartNewDuty(duty, quorum)
    AggregatorCommitteeRunner->>AggregatorCommitteeRunner: Initialize submission tracking
    
    Note over AggregatorCommitteeRunner: Pre-Consensus Phase
    AggregatorCommitteeRunner->>AggregatorCommitteeRunner: executeDuty()
    loop For each validator duty
        alt Aggregator duty
            AggregatorCommitteeRunner->>AggregatorCommitteeRunner: Sign slot (selection proof)
        else SyncCommittee duty
            loop For each subcommittee index
                AggregatorCommitteeRunner->>AggregatorCommitteeRunner: Sign SyncAggregatorSelectionData
            end
        end
    end
    AggregatorCommitteeRunner->>Network: Broadcast partial signatures
    
    AggregatorCommitteeRunner->>AggregatorCommitteeRunner: ProcessPreConsensus()
    AggregatorCommitteeRunner->>AggregatorCommitteeRunner: Reconstruct selection proof signatures
    alt Is Aggregator
        AggregatorCommitteeRunner->>BeaconNode: GetAggregateAttestation()
        BeaconNode-->>AggregatorCommitteeRunner: Attestation
        AggregatorCommitteeRunner->>AggregatorCommitteeRunner: Add to consensus data
    end
    alt Is SyncCommittee Aggregator
        AggregatorCommitteeRunner->>BeaconNode: GetSyncCommitteeContribution()
        BeaconNode-->>AggregatorCommitteeRunner: Contribution
        AggregatorCommitteeRunner->>AggregatorCommitteeRunner: Add to consensus data (dedupe by subnet)
    end
    
    Note over AggregatorCommitteeRunner: Consensus Phase
    AggregatorCommitteeRunner->>QBFT: Start consensus with AggregatorCommitteeConsensusData
    QBFT->>Network: Exchange consensus messages
    QBFT-->>AggregatorCommitteeRunner: Consensus decided
    
    Note over AggregatorCommitteeRunner: Post-Consensus Phase
    AggregatorCommitteeRunner->>AggregatorCommitteeRunner: ProcessConsensus()
    loop For each aggregator in consensus data
        AggregatorCommitteeRunner->>AggregatorCommitteeRunner: Sign AggregateAndProof
    end
    loop For each contributor in consensus data
        AggregatorCommitteeRunner->>AggregatorCommitteeRunner: Sign ContributionAndProof
    end
    AggregatorCommitteeRunner->>Network: Broadcast post-consensus partial signatures
    
    AggregatorCommitteeRunner->>AggregatorCommitteeRunner: ProcessPostConsensus()
    AggregatorCommitteeRunner->>AggregatorCommitteeRunner: Reconstruct final signatures
    loop For each duty with quorum
        alt Aggregator duty
            AggregatorCommitteeRunner->>BeaconNode: SubmitSignedAggregateSelectionProof()
            AggregatorCommitteeRunner->>AggregatorCommitteeRunner: RecordSubmission(aggregator)
        else SyncCommittee duty
            AggregatorCommitteeRunner->>BeaconNode: SubmitSignedContributionAndProof()
            AggregatorCommitteeRunner->>AggregatorCommitteeRunner: RecordSubmission(contribution)
        end
    end
    AggregatorCommitteeRunner->>AggregatorCommitteeRunner: Check if all duties submitted
    AggregatorCommitteeRunner->>AggregatorCommitteeRunner: Mark as Finished

Loading

[greptile-apps]

_{68 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Too many files changed for review.

[greptile-apps]

Too many files changed for review.

[greptile-apps]

Too many files changed for review.

[greptile-apps]

Too many files changed for review.

[greptile-apps]

Too many files changed for review.

[greptile-apps]

Too many files changed for review.

[greptile-apps]

Too many files changed for review.