Rename ValidatorConsensusData to ProposerConsensusData #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidator consensus data tests)
…subnet for contribution)
Contributor
|
Skipped: This PR changes more files than the configured file change limit: ( |
Comment on lines
-17
to
-18
| ValidatorRegistrationNoConsensusDataErrorCode | ||
| ValidatorExitNoConsensusDataErrorCode |
Contributor
There was a problem hiding this comment.
I think I asked before but why was this changed?
Contributor
There was a problem hiding this comment.
ok you changed Validate
Contributor
GalRogozinski
left a comment
GalRogozinski
left a comment
There was a problem hiding this comment.
Maybe let's add to the description the fact that the ConsensusData validation changed a bit. Just so that it is clear.
All the json changes obfusticate this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
ValidatorConsensusDatatype is currently only used for the block proposer duty.Thus, it's best to rename it and align to its usage.
This PR renames it to
ProposerConsensusData, changes its validation, and align tests.