spec tests: enable msg processing root check

[nkryuchkov]

We currently don't fail spec tests on root mismatch in MsgProcessingSpecTest

[greptile-apps]

Greptile Summary

This PR upgrades the post-duty runner state root check in MsgProcessingSpecTest.RunAsPartOfMultiTest from a non-failing logger.Error call to a test-failing require.EqualValues assertion. Previously, when the PostDutyRunnerStateRoot didn't match the actual computed root, the mismatch was only logged as an error but the test would pass silently. Now it properly fails the test with a diff of the expected vs actual state.

• Replaces logger.Error(...) with require.EqualValues(...) to enforce root equality in spec tests
• Extracts actualPostRoot variable to avoid redundant hex.EncodeToString computation
• Aligns with the pattern already used in multi_start_new_runner_duty_type.go (line 131)

Confidence Score: 4/5

• This PR is safe to merge — it strictly tightens test assertions without affecting production code.
• The change is minimal and well-scoped: it converts a silent log into a proper test failure assertion. It only affects test infrastructure, not production logic. The pattern matches what's already used in multi_start_new_runner_duty_type.go. One minor inconsistency exists (committee_msg_processing_type.go uses t.Errorf for the same check) but is out of scope.
• No files require special attention. The single changed file is straightforward.

Important Files Changed

Filename	Overview
protocol/v2/ssv/spectest/msg_processing_type.go	Replaces silent logger.Error with require.EqualValues to make root mismatch a test failure. Minor variable extraction for clarity. Change is correct and consistent with similar patterns elsewhere.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[RunAsPartOfMultiTest] --> B[runPreTesting: process messages]
    B --> C[Assert error codes]
    C --> D[Compare output messages]
    D --> E[Assert beacon broadcasted roots]
    E --> F[Compute postRoot via GetRoot]
    F --> G{PostDutyRunnerStateRoot == actualPostRoot?}
    G -- Yes --> H[Test passes]
    G -- No --> I[dumpState: compute diff]
    I --> J_OLD["BEFORE: logger.Error — test passes silently ❌"]
    I --> J_NEW["AFTER: require.EqualValues — test fails ✅"]

Loading

_{Last reviewed commit: c886984}

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Inconsistent root check in sibling file

Similar root mismatch check in committee_msg_processing_type.go:86-88 still uses t.Errorf (which marks the test as failed but does not stop execution), rather than require.EqualValues (which calls t.FailNow()). Consider applying the same upgrade there for consistency across spec tests.

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

[nkryuchkov]

@greptileai now it's consistent with multi_start_new_runner_duty_type.go

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.2%. Comparing base (f98fa34) to head (0ae92b7).
⚠️ Report is 1 commits behind head on stage.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.