Skip to content

Conversation

@dervoeti
Copy link
Member

Description

Has been on my todo list for a while, this adds some information to the Patchable README that was only available in Nuclino.

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

boil build <IMAGE> --image-version <RELEASE_VERSION> --strip-architecture --load
kind load docker-image <MANIFEST_URI> --name=<name-of-your-test-cluster>

See the output of boil to retrieve the image manifest URI for <MANIFEST_URI>.

@dervoeti dervoeti self-assigned this Nov 19, 2025
@dervoeti dervoeti force-pushed the docs/patchable-readme branch from a4369ef to 35ebe65 Compare November 19, 2025 11:13
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, a few small suggestions.

Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second half of the review done. Only two small comments, lgtm otherwise.

@dervoeti dervoeti requested a review from Techassi November 19, 2025 16:33
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from my side.

Maybe @NickLarsenNZ also wants to take a look (because you requested a review from him).

@dervoeti dervoeti added this pull request to the merge queue Nov 20, 2025
Merged via the queue into main with commit 980b2d9 Nov 20, 2025
3 checks passed
@dervoeti dervoeti deleted the docs/patchable-readme branch November 20, 2025 11:06
@dervoeti
Copy link
Member Author

Good from my side.

Maybe @NickLarsenNZ also wants to take a look (because you requested a review from him).

Thanks! Nah it's fine, I just requested it from him because we recently talked about it in a Slack thread. But you were probably even the better candidate to review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants