-
-
Notifications
You must be signed in to change notification settings - Fork 6
docs: extended Patchable readme #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a4369ef to
35ebe65
Compare
Techassi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review, a few small suggestions.
Co-authored-by: Techassi <[email protected]>
Co-authored-by: Techassi <[email protected]>
Co-authored-by: Techassi <[email protected]>
Techassi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second half of the review done. Only two small comments, lgtm otherwise.
Co-authored-by: Techassi <[email protected]>
Techassi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good from my side.
Maybe @NickLarsenNZ also wants to take a look (because you requested a review from him).
Thanks! Nah it's fine, I just requested it from him because we recently talked about it in a Slack thread. But you were probably even the better candidate to review this. |
Description
Has been on my todo list for a while, this adds some information to the Patchable README that was only available in Nuclino.
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
boilto retrieve the image manifest URI for<MANIFEST_URI>.