Skip to content

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Oct 16, 2024

Description

This is a follow-up for #849 and #890 and includes:

Integration tests ran locally successfully when the ✔️ is added

This is a follow-up for #849 and includes:

- The missing bits for Hive
- Kafka
- Kafka Testing Tools
- KCat
- NiFi
- Omid
- Spark (WIP)
- superset
# Conflicts:
#	CHANGELOG.md
#	hive/Dockerfile
#	kafka/Dockerfile
#	nifi/Dockerfile
#	omid/Dockerfile
#	opa/Dockerfile
#	spark-k8s/Dockerfile
- tools
@lfrancke lfrancke marked this pull request as ready for review October 17, 2024 08:41
@lfrancke lfrancke requested a review from NickLarsenNZ October 17, 2024 08:44
NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 23, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Left comments about things that should be picked up by hadolint (shellcheck), but then stopped. I can comment on the rest if you want, or we can leave those changes for another time.

@lfrancke lfrancke requested a review from NickLarsenNZ October 23, 2024 08:01
@lfrancke lfrancke enabled auto-merge October 23, 2024 08:10
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfrancke lfrancke added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 1e5f085 Oct 23, 2024
2 checks passed
@lfrancke lfrancke deleted the feat/user-handling-pt3 branch October 23, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants