Skip to content

feat: Add listener support #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 30, 2025
Merged

feat: Add listener support #17

merged 16 commits into from
Jul 30, 2025

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Jul 25, 2025 •
edited by siegfriedweber
Loading

Description

fixes #16

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

adwk67
adwk67 commented Jul 28, 2025
View reviewed changes
Copy link
Member Author

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few in-line comments where I'm not 100% certain about things. I've also left the cluster-wide service untouched - should this be removed and each role group listener address combiend and used for discovery.seed_hosts?

@adwk67 adwk67 marked this pull request as ready for review July 28, 2025 11:12
siegfriedweber
siegfriedweber requested changes Jul 29, 2025
View reviewed changes
adwk67 and others added 13 commits July 30, 2025 11:18
@adwk67 @siegfriedweber
Update docs/modules/opensearch/pages/usage-guide/listenerclass.adoc
31eceb1 
Co-authored-by: Siegfried Weber <[email protected]>
@adwk67 @siegfriedweber
Update docs/modules/opensearch/pages/usage-guide/listenerclass.adoc
03e7070 
Co-authored-by: Siegfried Weber <[email protected]>
@adwk67 @siegfriedweber
Update docs/modules/opensearch/partials/nav.adoc
ae186fc 
Co-authored-by: Siegfried Weber <[email protected]>
@adwk67 @siegfriedweber
Update rust/operator-binary/src/controller/build/role_group_builder.rs
469ae27 
Co-authored-by: Siegfried Weber <[email protected]>
@adwk67 @siegfriedweber
Update rust/operator-binary/src/controller/build/role_group_builder.rs
7d0981a 
Co-authored-by: Siegfried Weber <[email protected]>
@adwk67 @siegfriedweber
Update rust/operator-binary/src/crd/mod.rs
59596c4 
Co-authored-by: Siegfried Weber <[email protected]>
@adwk67 @siegfriedweber
Update tests/templates/kuttl/external-access/20-assert.yaml
ddcb858 
Co-authored-by: Siegfried Weber <[email protected]>
@adwk67 @siegfriedweber
Update tests/templates/kuttl/smoke/10-assert.yaml
576aa9e 
Co-authored-by: Siegfried Weber <[email protected]>
@adwk67 @siegfriedweber
Update rust/operator-binary/src/crd/mod.rs
e17ac67 
Co-authored-by: Siegfried Weber <[email protected]>
@adwk67
reverted assert, removed default function
bbfb9f8
@adwk67
missed owner ref
d3ac257
@adwk67
added listener test case
b5e2040
@adwk67
use versioned labels, move listener_pvc to framework module
ca3e9b1
@adwk67 adwk67 requested a review from siegfriedweber July 30, 2025 12:20
siegfriedweber
siegfriedweber approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67 adwk67 added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit ccf6161 Jul 30, 2025
17 checks passed
@adwk67 adwk67 deleted the feat/add-listener-support branch July 30, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the configuration of the service exposition per role group (Listener support)
2 participants
@adwk67 @siegfriedweber