Skip to content

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 13, 2025

Description

Adds a builder for a Probe similar to the ResourceRequirementsBuilder
Needed for stackabletech/superset-operator#654

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer requested a review from NickLarsenNZ August 15, 2025 09:58
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly reviewed, but I'd like to discuss the change I commented on.

@sbernauer sbernauer requested a review from NickLarsenNZ August 18, 2025 14:05
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Aug 19, 2025
Merged via the queue into main with commit b5f9a01 Aug 19, 2025
8 checks passed
@sbernauer sbernauer deleted the feat/add-probe-builder branch August 19, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants