Added comments based on my current understanding of the orchestration code for obtaining keytabs from AD #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
nightkr
reviewed
Jun 4, 2025
sbernauer
moved this from Development: In Review
to Development: Waiting for Review
in Stackable Engineering
sbernauer
approved these changes
Jul 25, 2025
| let mut stdin = child | ||
| .stdin | ||
| .take() | ||
| .expect("Failed to read from stdin of stackable-krb5-provision-keytab script! "); |
There was a problem hiding this comment.
I think this is a bit more accurate, but not sure
Suggested change
| .expect("Failed to read from stdin of stackable-krb5-provision-keytab script! "); | |
| .expect("Failed to read from stdin of stackable-krb5-provision-keytab command! "); |
There was a problem hiding this comment.
I must've missed that.. it's not even about reading, it's about taking ownership of the pipe. If it fails then you either didn't set up the pipe correctly (stdin(Stdio::piped())), or already took the pipe elsewhere.
There was a problem hiding this comment.
I just saw that you provided more details in #602 (comment), thanks!
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I read a small part of the code that is used to generate keytabs from AD and noted down my understanding in comments.
Not sure if correct or helpful to actually merge, but by opening a PR I hope to have a place for discussion.
Definition of Done Checklist
Author