Skip to content

Run containerdebug as a background job #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 13, 2024
Merged

Run containerdebug as a background job #881

merged 10 commits into from
Dec 13, 2024

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Nov 11, 2024 •
edited
Loading

Description

See stackabletech/issues#527

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
- [ ] Changes need to be "offline" compatible

# Reviewer
- [ ] Code contains useful comments
- [ ] Code contains useful logging statements
- [x] (Integration-)Test cases added
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
- [ ] [Roadmap](https://github.com/orgs/stackabletech/projects/25/views/1) has been updated

@nightkr nightkr marked this pull request as draft November 11, 2024 15:35
@nightkr nightkr mentioned this pull request Nov 18, 2024
Merged
@razvan razvan mentioned this pull request Dec 9, 2024
Closed
@razvan razvan self-requested a review December 11, 2024 10:58
@razvan razvan marked this pull request as ready for review December 11, 2024 10:58
razvan
razvan previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! tested locally

razvan
razvan previously approved these changes Dec 11, 2024
View reviewed changes
razvan
razvan previously approved these changes Dec 11, 2024
View reviewed changes
@razvan razvan self-requested a review December 11, 2024 13:11
nightkr
nightkr commented Dec 13, 2024
View reviewed changes
Copy link
Contributor Author

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightkr nightkr added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 646d08e Dec 13, 2024
17 checks passed
@nightkr nightkr deleted the feature/containerdebug branch December 13, 2024 13:55
@nightkr nightkr mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razvan razvan razvan approved these changes

Assignees

No one assigned

Labels

release/25.3.0

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nightkr @razvan @lfrancke