Skip to content

fix(networkinterface): Recognize the removal of allowed_addresses and… #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

Fyusel
Copy link
Contributor

@Fyusel Fyusel commented Aug 5, 2025

… security_group_ids from terraform config

Description

fixes #926

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Fyusel Fyusel requested a review from a team as a code owner August 5, 2025 14:28
@Fyusel Fyusel force-pushed the fix-network-interface-allowed-addresses branch 3 times, most recently from 5601767 to 49b360c Compare August 8, 2025 11:00
… security_group_ids from terraform config

Signed-off-by: Alexander Dahmen <[email protected]>
@Fyusel Fyusel force-pushed the fix-network-interface-allowed-addresses branch from 49b360c to ad91123 Compare August 8, 2025 12:49
Copy link

github-actions bot commented Aug 8, 2025

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkinterface 27.53% (-1.63%) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils 80.21% (+1.09%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/iaas/networkinterface/resource.go 31.73% (-2.18%) 249 (+16) 79 170 (+16) 👎
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/utils.go 78.12% (+1.85%) 64 (+5) 50 (+5) 14 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/utils_test.go

@Fyusel Fyusel merged commit f16b831 into main Aug 11, 2025
5 checks passed
@Fyusel Fyusel deleted the fix-network-interface-allowed-addresses branch August 11, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider doesn't recognize removal of allowed_addresses attribute from network interface
2 participants