Skip to content

Changes to build.py #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Changes to build.py #4

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d5d454e
Needed changes
jmucchiello Aug 26, 2023
5ab2533
Prevent copying examplemod.dll to the game.
jmucchiello Aug 27, 2023
b6dddd5
more boilerplate
jmucchiello Sep 6, 2023
03c3bf7
Update sample_food.jsont
jmucchiello Sep 6, 2023
2938a19
LogError
jmucchiello Sep 11, 2023
f2e78a7
first commit
jmucchiello Sep 30, 2023
55afa97
Update build.py
jmucchiello Oct 7, 2023
2bfe9c9
added Common folder
jmucchiello Oct 29, 2023
c2f2c2a
Update build.py
jmucchiello Nov 23, 2023
99e319c
Update build.py
jmucchiello Dec 24, 2023
d93038f
bbcode
jmucchiello Jan 13, 2024
efbae6c
Update Mod.csproj
jmucchiello Jan 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
bin/
obj/
obj/
.vs/
Icon Sources/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a personal thing, not something that should be in the template

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .vs/ thing kills me every time. I had to fork the mod-template. :)

*.user
5 changes: 5 additions & 0 deletions build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ def sync_folder(src: Path, dst: Path):
MOD_DLL = MOD_BIN / DLL_NAME
MOD_PATH = MODS_ROOT / MOD_ID

# check dll has unique name
if DLL_NAME.lower() == "examplemod.dll":
print("Did you forget to rename the DLL in the project settings?")
exit(1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a warning is enough here, maybe link to https://modding.stacklands.co/en/latest/guides/tutorial.html#step-1-setting-up-the-template as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why pull requests aren't requests. Not demands. At least put something there.


# copy dll
MOD_PATH.mkdir(exist_ok=True)
shutil.copyfile(MOD_DLL, MOD_PATH / f"{DLL_NAME}")
Expand Down
1 change: 1 addition & 0 deletions localization.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Term Notes English
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if including a localization file is a good choice

  • People going through the tutorial could be confused by it, as the tutorial tells them to download a completely different file
  • I assume most people would use a tool like Google Sheets to edit their localization files instead of a code/text editor
  • Even if the above assumption is incorrect, it's easy enough to create manually thanks to the localization guide

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm old school. I edit the file in visual studio directly.