Skip to content

Fix onDisappear modifier (fixes #230) #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

Fix onDisappear modifier (fixes #230) #232

merged 1 commit into from
Oct 24, 2025

Conversation

@stackotter
Copy link
Owner

OnDisappearModifier implemented the methods required by TypeSafeView, but conformed to View, so the custom method implementations were completely ignored. Easy fix once I figured out the issue.

MiaKoring
MiaKoring approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@MiaKoring MiaKoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and it works for me too, I see no reason why this couldn’t be merged.

@stackotter stackotter merged commit db3ce5c into main Oct 24, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MiaKoring MiaKoring MiaKoring approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stackotter @MiaKoring