Skip to content

Conversation

erthalion
Copy link
Contributor

Description

Currently no registry is set for nginx, with leads to a few issues:

  • It's being pulled from docker.io and sometimes bails out due to rate limiting.

  • With podman it can cause an issue with short-name resolution:

    short-name resolution enforced but cannot prompt without a TTY
    

Promote nginx from a non_qa to qa image.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Currently no registry is set for nginx, with leads to a few issues:

* It's being pulled from docker.io and sometimes bails out due to rate
  limiting.
* With podman it can cause an issue with short-name resolution:

    ```
    short-name resolution enforced but cannot prompt without a TTY
    ```

Promote nginx from a non_qa to qa image.
@erthalion erthalion requested a review from a team as a code owner August 8, 2025 09:24
@Molter73 Molter73 added build-builder-image rebuild-test-container Rebuild the collector-tests container. labels Aug 8, 2025
@JoukoVirtanen
Copy link
Contributor

Why was GetContainerPort changed to GetContainerPorts in the master branch, but not this branch?

@JoukoVirtanen
Copy link
Contributor

QA_TAG was changed to 2.0.3 in master and here. If the desired images for 3.20 and master have differences, could that lead to problems?

@erthalion erthalion force-pushed the fix/nginx-release-3.20 branch from 8cce9d6 to 0630bfe Compare August 27, 2025 14:27
@erthalion
Copy link
Contributor Author

Why was GetContainerPort changed to GetContainerPorts in the master branch, but not this branch?

It's a refactoring, which has nothing to do in a back-patch PR.

QA_TAG was changed to 2.0.3 in master and here. If the desired images for 3.20 and master have differences, could that lead to problems?

Theoretically yes, practically this would be visible in broken CI tests. No failures, no problem.

@ovalenti
Copy link
Contributor

QA_TAG was changed to 2.0.3 in master and here. If the desired images for 3.20 and master have differences, could that lead to problems?

Theoretically yes, practically this would be visible in broken CI tests. No failures, no problem.

As long as we end-up having the same definitions matching the same version numbers, I think it is fine. Actually, this looks like if we just had branched off master.

@erthalion erthalion enabled auto-merge (squash) August 28, 2025 09:35
Copy link
Contributor

@JoukoVirtanen JoukoVirtanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erthalion erthalion merged commit 934f1ef into release-3.20 Aug 28, 2025
315 of 341 checks passed
@erthalion erthalion deleted the fix/nginx-release-3.20 branch August 28, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-builder-image rebuild-test-container Rebuild the collector-tests container.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants