Miscellaneous resilience improvements #2358
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This zone does not have support for Arm VMs, which is causing it to fail the entire workflow when we rollover to it.
This is a newer approach to break out of loops in ansible which is closer to what we originally intended.
Stringy
approved these changes
Aug 18, 2025
ansible/requirements.txt
Outdated
Comment on lines
3
to
4
| ansible-core==2.18.7 | ||
| ansible==11.6.0 |
There was a problem hiding this comment.
I had to roll this back, there are many VMs that have older Python interpreters and are not compatible with the new ansible versions apparently
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2358 +/- ##
=======================================
Coverage 28.83% 28.83%
=======================================
Files 96 96
Lines 5799 5799
Branches 2551 2551
=======================================
Hits 1672 1672
Misses 3408 3408
Partials 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Molter73
force-pushed
the
mauro/ansible/miscellaneous-resilience-improvements
branch
from
df4c39b to
b42cb48
Compare
| @@ -7,7 +7,6 @@ gcp_instance_prefix: ci | |||
| gcp_available_zones: | |||
| - us-central1-a | |||
| - us-central1-b | |||
| - us-central1-c | |||
| - us-central1-f | |||
There was a problem hiding this comment.
Suggested change
| - us-central1-f | |
| - us-central1-f | |
| - us-central1-d |
There was a problem hiding this comment.
$ gcloud compute machine-types list --filter="name=t2a-standard-2 AND zone~'^us-'" --format="value(zone)"
us-central1-a
us-central1-b
us-central1-f
us-central1-d
robbycochran
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some improvements have been made to our ansible playbooks, namely:
us-central1-czone, since this one doesn't have Arm VM support.break_whenloop control, this is closer to our original intent.Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI should be enough.