Skip to content

ROX-27964: Support for CA rotation in Sensor #16304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: vb/central-secondary-ca-support
Choose a base branch
from

Conversation

vladbologa
Copy link
Contributor

@vladbologa vladbologa commented Aug 5, 2025

Description

WIP. Follow-up for #15312

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

Copy link

openshift-ci bot commented Aug 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Aug 5, 2025

Images are ready for the commit at 097c910.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-420-g097c91065a.

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 67.79661% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.07%. Comparing base (7b6dba6) to head (097c910).

Files with missing lines Patch % Lines
sensor/common/centralclient/client.go 50.00% 25 Missing and 4 partials ⚠️
sensor/kubernetes/certrefresh/ca_bundle.go 85.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           vb/central-secondary-ca-support   #16304      +/-   ##
===================================================================
+ Coverage                            49.06%   49.07%   +0.01%     
===================================================================
  Files                                 2627     2628       +1     
  Lines                               194092   194191      +99     
===================================================================
+ Hits                                 95222    95298      +76     
- Misses                               91408    91425      +17     
- Partials                              7462     7468       +6     
Flag Coverage Δ
go-unit-tests 49.07% <67.79%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vladbologa vladbologa force-pushed the vb/central-secondary-ca-support branch from 9180716 to 7b6dba6 Compare August 5, 2025 15:52
@vladbologa vladbologa force-pushed the vb/sensor-ca-rotation branch from 2b74e6d to 097c910 Compare August 5, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants