-
Notifications
You must be signed in to change notification settings - Fork 22
Split devenv into different node profiles. #307
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
==========================================
+ Coverage 41.49% 43.12% +1.62%
==========================================
Files 40 45 +5
Lines 5111 5359 +248
Branches 0 47 +47
==========================================
+ Hits 2121 2311 +190
- Misses 2990 3047 +57
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 5 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
Partially addresses #282. We would still need to revisit |
friedger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, haven't tested it yet.
|
The goal should probably be that we can run several signers as defined here: https://github.com/stacks-network/stacks-blockchain/blob/next/stacks-signer/README.md#generate-files |
Thanks for the heads up. My immediate goal is to unblock the integration pipeline. Adding support for a 'signer ring' profile sounds good too. Once we have more details, I can help with that if needed. I can see so far a few different use cases.
|
Summary of Changes
There's been some debate about the scope of
devenvs services. I'm exploring how to enable multiple 'devenv' profiles to cover a wider range of applications (core dev, third-party dev, testing). The immediate need is a minimal node with a local Romeo instance. I added a minimal profile with (bitcoind, stacks + RPC, electrs) for local romeo development.up/downcommands to support upping and downing 'min'/'full' nodes.Testing
Risks
Didn't fully test all util scripts. I don't expect any big complications, though.
How were these changes tested?
manual runs.
What future testing should occur?
Checklist: