fix: use correct annotation object #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
replaced #9 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with caller annotation handling by ensuring the correct annotation object is used throughout the codebase. The changes address bugs #19 and #8 while adding comprehensive test coverage for caller annotations using both wallet references and direct address formats.
- Fixes incorrect reference to
annotations.callerinstead offunctionAnnotations.caller - Adds support for direct address format in caller annotations (e.g.,
'ST000000000000000000002AMW42H) - Introduces comprehensive test coverage for caller annotation functionality
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/clarunit-generator.ts | Fixed bug using wrong annotation object and improved caller address handling |
| tests/contracts/generator-tests/annotations_test.clar | New test contract demonstrating caller annotation functionality |
| tests/contracts/parser-tests/simple-flow.clar | Added test case for caller annotation with direct address |
| tests/contracts/parser-tests/all-annotations.clar | Added test function with direct address caller annotation |
| tests/clarity-parser.test.ts | Added test assertion for parsing direct address caller annotations |
| tests/clarity-parser-flow.test.ts | Added test verification for flow parsing with direct address caller |
| tests/clarunit.test.ts | Basic test setup file for clarunit functionality |
| example/tests/my-contract_test.clar | Example usage of direct address caller annotation |
| deployments/default.simnet-plan.yaml | Configuration to include new test contract in deployment |
| Clarinet.toml | Contract registration for new annotations test contract |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Great! |
|
Waiting on a fix of stx-labs/clarinet#1985 to make the tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
The example fails until a new npm package was released