Feat/signer two phase commit impl #6319
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…e throughout Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/signer-two-phase-commit-impl
… into feat/signer-two-phase-commit-impl
… into feat/signer-two-phase-commit-impl
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/signer-two-phase-commit-impl
hstove
previously approved these changes
Jul 31, 2025
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…lock Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
force-pushed
the
feat/signer-two-phase-commit-impl
branch
from
bd04283 to
e304a48
Compare
… than Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
… into feat/signer-two-phase-commit-impl
Signed-off-by: Jacinta Ferrant <[email protected]>
… wait for block commit at correct height Signed-off-by: Jacinta Ferrant <[email protected]>
…n block Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
force-pushed
the
feat/signer-two-phase-commit-impl
branch
from
d46d4ec to
0375c72
Compare
hstove
previously approved these changes
Aug 5, 2025
Signed-off-by: Jacinta Ferrant <[email protected]>
hstove
previously approved these changes
Aug 5, 2025
… into feat/signer-two-phase-commit-impl
Signed-off-by: Jacinta Ferrant <[email protected]>
kantai
reviewed
Aug 15, 2025
stacks-signer/src/v0/signer.rs
Outdated
Comment on lines
1290
to
1405
| let block_response = self.create_block_acceptance(&block_info.block); | ||
| self.send_block_pre_commit(signer_signature_hash); | ||
| // have to save the signature _after_ the block info | ||
| self.handle_block_signature(stacks_client, block_response.as_block_accepted()?); | ||
| Some(block_response) | ||
| let address = self.stacks_address; | ||
| self.handle_block_pre_commit(stacks_client, &address, &signer_signature_hash); |
There was a problem hiding this comment.
This behavior has to be gated by the signer protocol version, right? Otherwise, when signers upgrade, they won't sign blocks until 70% of signers upgrade.
There was a problem hiding this comment.
They still work with unupgraded signers. They just treat signatures as pre commits if they haven't seen a pre commit from the signer yet. (I have tested this exact scenario in a docker container successfully)
There was a problem hiding this comment.
It does mean though that upgraded signers send a message that unupgraded signers ignore. Eventualyl though upgraded signers see 70% weight signatures (which they have treated as commits) and issue their signature which unupgraded signers accept no problem.
There was a problem hiding this comment.
Added an integration test to demonstrate how it works with unupgraded vs upgraded signers: see a584982
… into feat/signer-two-phase-commit-impl
Signed-off-by: Jacinta Ferrant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6099