Ephemeral MARF #6365
Draft
Ephemeral MARF #6365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e on disk, and a RAM-backed MARF store which loads data from a read-only handle. Implement ClarityBlockStore for the ephemeral variant
moodmosaic
reviewed
Aug 11, 2025
| /// Otherwise, use the disk-backed one. | ||
| fn get_open_chain_tip_height(&mut self) -> u32 { | ||
| if let EphemeralTip::RAM(..) = &self.open_tip { | ||
| self.ephemeral_marf |
There was a problem hiding this comment.
I think this computes the RAM tip height and then discards it. Should we return that value + base_tip_height (similar to get_current_block_height)?
I added an invariant prop_ephemeral_tip_height_matches_current in the companion PR; it fails here and passes with this change: https://github.com/jcnelson/stacks-core/pull/1/files
There was a problem hiding this comment.
Yes, you are correct. Thanks!
fix: correct ephemeral open-tip height
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements #6350 by re-implementing
WritableMarfStoreas an enum of a persistent disk-backed variant (the one we currently have), and a new ephemeral variant in which writes are committed to a RAM-backed Sqlite store, and in which reads will hit both the in-RAM sqlite store and an internalReadOnlyMarfStorehandle. This feature will be used to allow the node to replay blocks without the possibility of committing them to disk.Applicable issues
Additional info (benefits, drawbacks, caveats)
A caveat: blocks produced with the ephemeral variant will not have the same state root hash as they would have had they been produced with the persistent variant. This is a consequence of the fact that the new block's MARF key/value pairs and side-storage live in a separate MARF, whose trie is not linked to the disk-backed parent trie. This is acceptable because the purpose of this PR is to allow the node to replay already-processed blocks in order to extract the transaction receipts. The node already knows the "true" state root hash.
This PR is a draft until it has enough test coverage.
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml